Make possible to upload SVG logo by admin #1048
Conversation
|
Hi, @cbmd, |
|
@vrann I do think that it can be done in more general class, but in case "just for logo" we avoid situations where it can be uploaded for example for products (which is useless usage of image type, as i think). But we could discuss this one with community :) |
|
So i meant that this type of images should be used carefully, since in some cases it will dramatically increase image size instead of making it better in performance and usability wise... |
|
@cbmd thanks, I see your reasons. Can you please cover the contribution with tests? It is something we ask contributors to do as a part of https://github.com/magento/magento2/wiki/Contribution-Guide Tracking number MAGETWO-34527 |
vrann
added
Progress: needs update
Issue: Ready for Work
|
@cbmd Any updates on this? |
|
@anupdugar @vrann Sorry about delay, i will provide them ASAP for sure, busy weeks... |
|
@cbmd, do you have any news for us? |
|
@cbmd this change is covered with the test in internal codebase. We will merge this PR soon. Thanks! |
|
@cbmd can you please make sure that there is no conflicts in the files you contributed with the latest from the mainline. Backend models were moved to the Config module. |
|
@cbmd I've resolved conflict internally. No other changes is need. Please don't do any other change. |
|
@cbmd, this is now included in 0.74.0-beta1. Thank you again for your contribution and continued support in Magento! |
- MAGETWO-65470: The visibility conditions improvements
Nowadays it is pretty useful to have an option to upload SVG logo, since this will reduce assets that needs for all different devices to be rendered perfectly.